Stopping GUI Goose via the stop button does not terminate background processes

[alecthomas]

Describe the bug Goose ran "pnpm start" on a Docusaurus site (even though I asked it to build it), which never terminates.

To Reproduce Steps to reproduce the behavior:

1. Tell Goose to run some process in the background.
2. Click stop.

Expected behavior Goose should terminate any processes started during execution.

Please provide following information:

• OS & Arch: macOS Sequoia
• Interface: GUI
• Version: v1.0.0
• Extensions enabled: Devloper
• Provider & Model: "goose" (internal)

[michaelneale]

note it won't necessarily stop goosed - but should stop ones that the agent itself launched yes... which would be a problem as it isn't. related: https://github.com/block/goose/issues/1075 as non trivial (but should kill/drop, as used to)

[alecthomas]

FYI I don't think this is a GUI issue. I was just able to reproduce this with the CLI:

( O)> Run "cd docs && pnpm start"
I'll run that command using the shell tool:

─── shell | developer ──────────────────────────
command: cd docs && pnpm start



It seems we need to reinstall the dependencies. Let me try that:

─── shell | developer ──────────────────────────
command: cd docs && pnpm install && pnpm start


◓  Molting old code...                                                               ^CWe interrupted the existing call to developer__shell. How would you like to proceed?

( O)> 
Input error: EOF
Closing session. Recorded to /Users/aat/.config/goose/sessions/hd8DTqPn.jsonl

🐚 ~/dev/ftl $ ps xaw | grep pnpm
18725 s000  S      0:00.01 bash -c cd docs && pnpm install && pnpm start 2>&1
18859 s000  S      0:00.21 /Users/aat/Library/Caches/hermit/pkg/pnpm-9.15.5/pnpm start
19044 s000  R+     0:00.00 grep pnpm

[zakiali]

I'm not seeing this issue in the cli or app in recent versions. Closing this out, but feel free to reopen if the issue comes back