blitz icon indicating copy to clipboard operation
blitz copied to clipboard

fix detecting `blitz.config.(ts|js)` config file

Open oltdaniel opened this issue 3 years ago • 1 comments

the presence of the tsconfig.json is not enough to indicate whether our blitz.config.* is a typescript or javascript file. this commit fixes the detection and logging of which file will be moved.

Closes: None

What are the changes and their implications?

The detection of the blitz.config.* file is no more precise, by ignoring the presence of the tsconfig.json, as we cannot determine based on that if the config file itself is written in Typescript. This fixes this detection and also fixes the logging of which file has been detected.

NOTE I'm not sure if the usage of [0] is clean enough, maybe something like a .reduce is nicer? Or replace everything with some if code.

Bug Checklist

  • [ ] Integration test added (see test docs if needed)

Feature Checklist

oltdaniel avatar Aug 09 '22 14:08 oltdaniel

🦋 Changeset detected

Latest commit: 455cd354ac3e719fe7b9f1286eeeb4bfe84ae14e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@blitzjs/codemod Patch
@blitzjs/auth Patch
@blitzjs/next Patch
@blitzjs/rpc Patch
@blitzjs/config Patch
@blitzjs/generator Patch
@blitzjs/recipe-base-web Patch
@blitzjs/recipe-bulma Patch
@blitzjs/recipe-bumbag-ui Patch
@blitzjs/recipe-chakra-ui Patch
@blitzjs/recipe-emotion Patch
@blitzjs/recipe-gh-action-yarn-mariadb Patch
@blitzjs/recipe-gh-action-yarn-postgres Patch
@blitzjs/recipe-ghost Patch
@blitzjs/recipe-graphql Patch
@blitzjs/recipe-logrocket Patch
@blitzjs/recipe-material-ui Patch
@blitzjs/recipe-next-ui Patch
@blitzjs/recipe-passenger Patch
@blitzjs/recipe-quirrel Patch
@blitzjs/recipe-reflexjs Patch
@blitzjs/recipe-render Patch
@blitzjs/recipe-secureheaders Patch
@blitzjs/recipe-stitches Patch
@blitzjs/recipe-styled-components Patch
@blitzjs/recipe-tailwind Patch
@blitzjs/recipe-theme-ui Patch
@blitzjs/recipe-vanilla-extract Patch
blitz Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Aug 09 '22 14:08 changeset-bot[bot]