Add support for statuses

Open Djiit opened this issue 3 years ago • 1 comments

Hi,

Thanks for your action; it's pretty convenient in our monorepo environment.

Some of our "checks" are in fact "statuses" (see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/about-status-checks) POSTed to Github API by custom tools and I'm wondering how hard it would be to add support for statuses on top of regular checks ? Right now, the action just don't recognize the statuses; and wait for "checks" until timing out.

Maybe adding statuses here would be a start? https://github.com/blend/require-conditional-status-checks/blob/development/pkg/requireconditional/run.go#L117

Happy to have any guidance before I have a look at it.

Thanks

May 25 '22 06:05 Djiit

The checks-yaml gets deserialized onto https://github.com/blend/require-conditional-status-checks/blob/26fa07ee9d2d32d4c13df1b2c955b85fe5032ca0/pkg/requireconditional/check.go#L31-L35

@ZacharyBenamram it may make sense to expand that type to include something other than a GitHub Actions check?

May 25 '22 14:05 dhermes