go-sdk icon indicating copy to clipboard operation
go-sdk copied to clipboard
verified publisher icon blend

Span type and span operation name for `oauthtrace` are generic HTTP

Open dhermes opened this issue 6 years ago • 0 comments

See

https://github.com/blend/go-sdk/blob/e7d08d510b515a147af92fa3a8f0483b612770c6/stats/tracing/oauthtrace/tracer.go#L30-L33

The span.type=http tag and operationName=http.request in the StartSpanFromContext() don't seem specific enough to OAuth.

The OperationHTTPRequest is used in stats/tracing/oauthtrace, stats/tracing/r2trace and stats/tracing/webtrace (as of e7d08d510b515a147af92fa3a8f0483b612770c6) and SpanTypeHTTP is used in stats/tracing/oauthtrace and stats/tracing/r2trace.

dhermes avatar Jan 15 '20 19:01 dhermes