cmess icon indicating copy to clipboard operation
cmess copied to clipboard

Fixes the Warning forwarding to private method by making methods public

Open rebelwarrior opened this issue 6 years ago • 2 comments

I could find no reason to keep the methods private, so made the public.

Changes:

  • Made public :supported_encoding? and :supported_bom?
  • Bumped up the minor version
  • Added rubocop.yml
  • Ran rubocop linter with autocorrect
  • Fixed certain rubocop errors
  • Added TODOs for large rubocop errors (for a future pull request from me)

Please squash merge (commits are messy) if accepted.

rebelwarrior avatar Mar 06 '19 16:03 rebelwarrior

Btw I might be interested in taking over maintenance of the gem if you help me understand it and write some tests.

rebelwarrior avatar Mar 08 '19 20:03 rebelwarrior

That sounds great, thanks for stepping up! I will certainly try to answer any questions you might have in a timely manner. But I can't make any promises as to providing a basic test suite; I may get around to it, but I also might not. Sorry!

May I ask in which context you're using cmess (and which parts in particular) and what your mid- to long-term commitment will look like? I will give you commit access to the repository and push rights for the gem and stay out of your way, but I also kinda wanna make sure that it's in good hands ;)

blackwinter avatar Mar 08 '19 21:03 blackwinter