hub icon indicating copy to clipboard operation
hub copied to clipboard

feat(blackduck): argoCD hooks

Open abdennour opened this issue 4 years ago • 6 comments

ArgoCD uses Helm just as YAML generator. Custom ArgoCD plugins ignore helm hooks as well.

More details: https://argo-cd.readthedocs.io/en/stable/user-guide/helm/

Signed-off-by: abdennour

abdennour avatar Dec 03 '21 18:12 abdennour

@shehroz please FYA

abdennour avatar Dec 06 '21 08:12 abdennour

@pcentrella FYI please

abdennour avatar Dec 14 '21 07:12 abdennour

Thank you for the PR. I understand the utility for ArgoCD, but this adds specificity that doesn't apply for all use cases, customers, and scenarios. It could, however, be advantageous to provide a some form of generic annotations definition in the helper to allow customers to define annotations to meet their specific use case scenarios such as ArgoCD integration.

skatzman-synopsys avatar Dec 14 '21 14:12 skatzman-synopsys

@skatzman-synopsys thank you for sparing time to review the PR. I do partially agree. Accordingly, we can add flag like .Values.managedByArgoCD and if it's "true", we should inject those annotations, instead of having it hard-coded as now. Please let me know if this work, so i can update PR accordingly

abdennour avatar Dec 14 '21 21:12 abdennour

Filed internal issue HUB-32224 to prioritize and track this change request. This pull request should remain open in alignment with HUB-32224 resolution.

skatzman-synopsys avatar Dec 14 '21 21:12 skatzman-synopsys