Gut icon indicating copy to clipboard operation
Gut copied to clipboard

Change orange color of "Run Summary" and "Totals"

Open gustavi opened this issue 4 years ago • 4 comments

The orange color is used by GUT (and more generally) to indicate a warning but when all tests passed "Run Summary" and "Totals" are displayed in orange too.

image

I suggest to change the color to something more neutral and less confusing (green ? white ?). Quite weird to have all good and the same time some messages at the same color of warnings.

If you agree with this I can submit a PR.

Thank you for this amazing tool.

gustavi avatar Mar 19 '21 08:03 gustavi

Although I do see some room for improvement, I don't think changing the color is the solution.

The actual color is yellow and was picked to "pop" to make the summary and totals stand out more. It looks different depending on where you view it. Different terminal settings can change what "yellow" is. The GUI also shares this same color but it is created in a different manner.

Here is the same output in 3 different places on my mac. image

Given

  • there are a ton of ways it could appear based on your environment
  • there is probably 20 valid arguments for 20 different colors/text format I think that the only way to address this for everyone would be to come up with some sort of templating system that would allow the user to specify colors and text for the various sections in the output.

I'm not sure how important that is, but I think it could be done easier if we implement #207 first. This might not help at the command line, but automatically popping up a summary window that displays the formatted xml should be trivial.

bitwes avatar Mar 22 '21 19:03 bitwes

The main issue I have is the inconsistency of output colors, the specially the orange/yellow (let's say yellow in the future).

The yellow is used by Godot (and almost all CLI) for warnings, when something important and not normal occurred. For example :

image

It's quite weird to have "Run summary" and "Totals" with the same color. After days and hundreds of cli launches it sill catch my eyes. I often think if forget an orphan node.

In the following screenshot the warning should be in yellow

2021-03-22_20-54

I agree that a template for output could be a solution. May be quite overkill but everybody will be happy :)

gustavi avatar Mar 22 '21 20:03 gustavi

Maybe yellow was the wrong choice. I'll think about it. I just don't want to end up changing it back later.

bitwes avatar Mar 23 '21 15:03 bitwes

Speaking of colours, i made a multicolour summary line for my own needs. It looks like this:

Gut_multicolour_summary

Here's the implementation if someone's interested.

hilfazer avatar Apr 02 '21 18:04 hilfazer