server icon indicating copy to clipboard operation
server copied to clipboard

Bre-917/base-image-testing

Open aj-bw opened this issue 7 months ago â€ĸ 3 comments

đŸŽŸī¸ Tracking

BRE-917 PoC / testing branch

📔 Objective

test other base images for server containers

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

aj-bw avatar Jun 17 '25 13:06 aj-bw

Logo Checkmarx One – Scan Summary & Details – 5c398ab4-0aa3-4400-9f25-a3633f4ff5d7

Fixed Issues (1)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM ~~Use_Of_Hardcoded_Password~~ /src/Core/KeyManagement/Sends/SendPasswordHasherServiceCollectionExtensions.cs: 14

github-actions[bot] avatar Jun 17 '25 13:06 github-actions[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 48.45%. Comparing base (4464bfe) to head (8f9b8b4). :warning: Report is 25 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5976      +/-   ##
==========================================
+ Coverage   48.36%   48.45%   +0.09%     
==========================================
  Files        1732     1739       +7     
  Lines       76459    77232     +773     
  Branches     6824     6906      +82     
==========================================
+ Hits        36980    37426     +446     
- Misses      37993    38300     +307     
- Partials     1486     1506      +20     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 17 '25 13:06 codecov[bot]

@dani-garcia @tangowithfoxtrot this is ready for re-review! sorry had to tweak a few things after discussion with others on BRE regarding the entrypoint scripts and needed to ensure the setup container was working as expected. cc @mandreko-bitwarden on this one as well

aj-bw avatar Jul 11 '25 19:07 aj-bw

@tangowithfoxtrot after some testing with @keithhubner he noticed I was missing krb5 for a few services. pushed a commit adding them

aj-bw avatar Jul 24 '25 23:07 aj-bw