Bre-917/base-image-testing
đī¸ Tracking
BRE-917 PoC / testing branch
đ Objective
test other base images for server containers
â° Reminders before review
- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team
đĻŽ Reviewer guidelines
- đ (
:+1:) or similar for great changes - đ (
:memo:) or âšī¸ (:information_source:) for notes or general info - â (
:question:) for questions - đ¤ (
:thinking:) or đ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - đ¨ (
:art:) for suggestions / improvements - â (
:x:) or â ī¸ (:warning:) for more significant problems or concerns needing attention - đą (
:seedling:) or âģī¸ (:recycle:) for future improvements or indications of technical debt - â (
:pick:) for minor or nitpick changes
Checkmarx One â Scan Summary & Details â 5c398ab4-0aa3-4400-9f25-a3633f4ff5d7
Fixed Issues (1)
Great job! The following issues were fixed in this Pull Request
| Severity | Issue | Source File / Package |
|---|---|---|
![]() |
~~Use_Of_Hardcoded_Password~~ | /src/Core/KeyManagement/Sends/SendPasswordHasherServiceCollectionExtensions.cs: 14 |
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.45%. Comparing base (4464bfe) to head (8f9b8b4).
:warning: Report is 25 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #5976 +/- ##
==========================================
+ Coverage 48.36% 48.45% +0.09%
==========================================
Files 1732 1739 +7
Lines 76459 77232 +773
Branches 6824 6906 +82
==========================================
+ Hits 36980 37426 +446
- Misses 37993 38300 +307
- Partials 1486 1506 +20
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@dani-garcia @tangowithfoxtrot this is ready for re-review! sorry had to tweak a few things after discussion with others on BRE regarding the entrypoint scripts and needed to ensure the setup container was working as expected. cc @mandreko-bitwarden on this one as well
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
13 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
@tangowithfoxtrot after some testing with @keithhubner he noticed I was missing krb5 for a few services. pushed a commit adding them
