server [PM-22503] Fix manage cipher permission

🎟️ Tracking

PM-22503

📔 Objective

This fixes what manage gets set to on a cipher when a cipher is shared between two collections a user has access to.

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

Jun 16 '25 16:06 jrmccannon

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 50.99%. Comparing base (66d1c70) to head (c8c8b44). Report is 14 commits behind head on main.

Files with missing lines	Patch %	Lines
...tyFramework/Vault/Repositories/CipherRepository.cs	85.71%	0 Missing and 1 partial :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5972      +/-   ##
==========================================
+ Coverage   47.62%   50.99%   +3.36%     
==========================================
  Files        1665     1673       +8     
  Lines       75117    75205      +88     
  Branches     6772     6767       -5     
==========================================
+ Hits        35775    38349    +2574     
+ Misses      37884    35337    -2547     
- Partials     1458     1519      +61

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

:snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
:package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.