server icon indicating copy to clipboard operation
server copied to clipboard

[PM-10314] Auto-enable Single Org when a Domain is Verified

Open jrmccannon opened this issue 1 year ago â€ĸ 2 comments

đŸŽŸī¸ Tracking

https://bitwarden.atlassian.net/browse/PM-10330

📔 Objective

This is to allow for the auto enabling of the Single Org Policy when a claimed domain is verified. This will also block a user from disabling the Single Org Policy if the organization has any verified domains.

This also included a refatctor of the ValidateOrganizationDomain scheduled job to use the VerifyOrganizationDomainCommand. This also required a refactor of the command to allow for it to be called by user action or the background job.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

jrmccannon avatar Oct 15 '24 21:10 jrmccannon

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 42.31%. Comparing base (a952d10) to head (b4833b1). Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4897      +/-   ##
==========================================
+ Coverage   42.29%   42.31%   +0.02%     
==========================================
  Files        1384     1385       +1     
  Lines       64528    64550      +22     
  Branches     5930     5932       +2     
==========================================
+ Hits        27289    27314      +25     
+ Misses      36010    36007       -3     
  Partials     1229     1229              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 15 '24 21:10 codecov[bot]

Logo Checkmarx One – Scan Summary & Details – 3c190cef-742b-4b4c-8cf0-f408dacb410d

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Privacy_Violation /src/Core/Auth/Services/Implementations/AuthRequestService.cs: 213 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM CSRF /src/Billing/Controllers/RecoveryController.cs: 38
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 107
MEDIUM CSRF /src/Api/Controllers/PushController.cs: 38
MEDIUM CSRF /src/Admin/AdminConsole/Controllers/OrganizationsController.cs: 351
MEDIUM CSRF /src/Billing/Controllers/StripeController.cs: 164
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/MembersController.cs: 96
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 227
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 107
MEDIUM CSRF /src/Api/AdminConsole/Controllers/PoliciesController.cs: 58
MEDIUM CSRF /src/Api/AdminConsole/Controllers/PoliciesController.cs: 75
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/PoliciesController.cs: 42
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/PoliciesController.cs: 62
MEDIUM CSRF /src/Admin/AdminConsole/Controllers/OrganizationsController.cs: 351
MEDIUM CSRF /src/Api/Controllers/PushController.cs: 38
MEDIUM CSRF /src/Api/Controllers/PushController.cs: 38
MEDIUM Privacy_Violation /src/Core/Auth/Services/Implementations/AuthRequestService.cs: 208
LOW Log_Forging /src/Api/Vault/Controllers/CiphersController.cs: 170

github-actions[bot] avatar Oct 15 '24 21:10 github-actions[bot]