server
server copied to clipboard
Remove AcceptOrgUserByOrgId from AcceptOrgUserCommand to simplify interface
Type of change
- [ ] Bug fix
- [ ] New feature development
- [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other
Objective
In researching a bug, I identified that there was the potential to remove one of the methods by which we accept a user into an org. We could simplify the interface and also avoid re-retrieving the OrganizationUser when we already have it in the calling method.
Code changes
- file.ext: Description of what was changed and why
Before you submit
- Please check for formatting errors (
dotnet format --verify-no-changes) (required) - If making database changes - make sure you also update Entity Framework queries and/or migrations
- Please add unit tests where it makes sense to do so (encouraged but not required)
- If this change requires a documentation update - notify the documentation team
- If this change has particular deployment requirements - notify the DevOps team
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
974d23e) 32.43% compared to head (4d18976) 32.43%. Report is 1 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #3683 +/- ##
=======================================
Coverage 32.43% 32.43%
=======================================
Files 1212 1212
Lines 63199 63153 -46
Branches 4754 4751 -3
=======================================
- Hits 20497 20486 -11
+ Misses 41658 41623 -35
Partials 1044 1044
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.