server icon indicating copy to clipboard operation
server copied to clipboard

[PS-1368] Make Entities `Nullable`

Open justindbaur opened this issue 3 years ago • 1 comments

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Add nullable annotations on all of our types that correspond to tables in SQL.

Code changes

  • Most Added #nullable to all entities files and changed their annotations to abide by their SQL constraints.
  • src/Api/Controllers/OrganizationExportController.cs: Fixed a dotnet format complaint

Before you submit

- [x] I have checked for formatting errors (`dotnet format --verify-no-changes`) (required)
- [ ] If making database changes - I have also updated Entity Framework queries and/or migrations
- [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required)
- [ ] This change requires a **documentation update** (notify the documentation team)
- [ ] This change has particular **deployment requirements** (notify the DevOps team)

justindbaur avatar Aug 26 '22 13:08 justindbaur

@MGibson1 Probably just a couple BEEEP days if I can get the reviews, my plan is Entities (this) -> Repositories -> Services -> Rest of src/* and then we can discuss if we want it on in tests or not.

justindbaur avatar Jan 13 '23 17:01 justindbaur