passwordless-server icon indicating copy to clipboard operation
passwordless-server copied to clipboard

Improve integration tests performance

Open jonashendrickx opened this issue 1 year ago • 1 comments

Description

Significantly reduces the resources required to run the integration tests as it reuses the Microsoft SQL Server test container.

If the tests are properly written, we should not see any issues. In case we do need a unique instance, we can just use a different collection identifier.

Shape

Screenshots

Checklist

I did the following to ensure that my changes were tested thoroughly:

  • __

I did the following to ensure that my changes do not introduce security vulnerabilities:

  • __

jonashendrickx avatar Aug 20 '24 07:08 jonashendrickx

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 34.88%. Comparing base (c1bb7c5) to head (0405932). Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #689   +/-   ##
=======================================
  Coverage   34.88%   34.88%           
=======================================
  Files         566      566           
  Lines       30995    30995           
  Branches      933      933           
=======================================
  Hits        10814    10814           
  Misses      20038    20038           
  Partials      143      143           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 20 '24 08:08 codecov[bot]

In case we do need a unique instance, we can just use a different collection identifier.

We can also re-use the same MSSQL instance but access different database instances.

Tyrrrz avatar Aug 20 '24 13:08 Tyrrrz