mobile icon indicating copy to clipboard operation
mobile copied to clipboard
verified publisher icon bitwarden

[PM-950] Cannot save new login if personal ownership is disabled

Open LRNcardozoWDF opened this issue 1 year ago • 0 comments

Type of change

  • [X] Bug fix
  • [ ] New feature development
  • [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • [ ] Build/deploy pipeline (DevOps)
  • [ ] Other

Objective

Fixes https://github.com/bitwarden/mobile-maui/issues/1874

Add the ability to select a collection for the new item if personal ownership is disabled.

Code changes

  • LoginAddViewController.cs: Refactor how the number of rows and sections are calculated based on the value of the flag _personalOwnershipPolicyApplies. Added cells to warn the user the personal ownership is disabled and allow organisation and collection selection.
  • FormEntryTableViewCell.cs: Allow a form entry empty.

Screenshots

BEFORE image

AFTER image image

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

LRNcardozoWDF avatar May 28 '24 21:05 LRNcardozoWDF