clients icon indicating copy to clipboard operation
clients copied to clipboard

[PM-7029] Remove key-rotation-feature-flag

Open trmartin4 opened this issue 2 years ago • 2 comments

Type of change

- [ ] Bug fix
- [ ] New feature development
- [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Removed the key-rotation-feature-flag from clients code.

This was causing https://github.com/bitwarden/clients/issues/8453 for self-hosted customers with the flag off. Rather than try to fix the issue, I elected to remove the flag as the feature has already been enabled.

See corresponding server PR: https://github.com/bitwarden/server/pull/4002

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

trmartin4 avatar Apr 18 '24 18:04 trmartin4

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 27.75%. Comparing base (7bb8cae) to head (e4a41ea). Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8816      +/-   ##
==========================================
- Coverage   27.76%   27.75%   -0.01%     
==========================================
  Files        2419     2419              
  Lines       70042    70024      -18     
  Branches    13046    13042       -4     
==========================================
- Hits        19444    19435       -9     
+ Misses      49085    49077       -8     
+ Partials     1513     1512       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 18 '24 19:04 codecov[bot]

Logo Checkmarx One – Scan Summary & Detailsbd93d523-7448-4fbf-8f55-4813353b4505

No New Or Fixed Issues Found

github-actions[bot] avatar Apr 18 '24 19:04 github-actions[bot]