timex icon indicating copy to clipboard operation
timex copied to clipboard

Relax gettext dependency constraint to allow >= 0.26.0

Open patrols opened this issue 4 months ago • 7 comments

Summary of changes

Relax gettext dependency constraint to allow >= 0.26.0 This allows users to choose between gettext 0.26.x and 1.0.x versions

gettext 1.0.0 changelog

Checklist

  • N/A New functions have typespecs, changed functions were updated
  • N/A Same for documentation, including moduledocs
  • N/A Tests were added or updated to cover changes
  • [x] Commits were squashed into a single coherent commit
  • [x] Notes added to CHANGELOG file which describe changes at a high-level

Fixes #782

patrols avatar Sep 14 '25 10:09 patrols

Yes, would nice, we also can't update our lib without this

ddon avatar Sep 15 '25 19:09 ddon

+1. Can we merge it?

tispratik avatar Sep 29 '25 13:09 tispratik

Would be really nice!

ddon avatar Sep 29 '25 15:09 ddon

need it too

mberrueta-cn avatar Oct 20 '25 21:10 mberrueta-cn

@ddon @mberrueta-cn I'm curious why you need this PR so badly. Is there anything preventing you from doing {:gettext, "~> 1.0", override: true} as a workaround for now?

optikfluffel avatar Oct 22 '25 08:10 optikfluffel

@bitwalker have you already seen this?

SebastianMueller87 avatar Oct 22 '25 11:10 SebastianMueller87

@optikfluffel the answer is in your question: it's a workaround. Not everybody wants to have workarounds in their code. Not every dev might be sure that the override is safe in this case.

The question should be "Is there anything preventing this from being merged and released?", not the other way round.

lwld avatar Nov 17 '25 12:11 lwld