libgraph icon indicating copy to clipboard operation
libgraph copied to clipboard

Fix #80 -- improve efficiency of delete_vertex and #85 improve efficiency of replace_vertex

Open stevensonmt opened this issue 1 year ago • 5 comments

  • fix #80
  • ready for PR

stevensonmt avatar Jan 11 '25 17:01 stevensonmt

I don't understand the errors from the CI run. If someone can point me in the right direction I will try to resolve it, but I think it might be pointing more to how the CI runs are configured?

stevensonmt avatar Jan 11 '25 17:01 stevensonmt

included #85 in this PR.

stevensonmt avatar Jan 11 '25 22:01 stevensonmt

sorry, don't know why that stupid lexical log keeps showing up even after adding it to gitignore and deleting the directory (vim creates it again when it tries to use lexical for LSP).

stevensonmt avatar Jan 14 '25 04:01 stevensonmt

Hey @bitwalker!

Just checking in about this PR - the performance fixes here would be really helpful for Hologram when handling large graphs. Any chance you'll be able to take a look at it soon?

bartblast avatar Mar 28 '25 13:03 bartblast

I ran into this CI issue with my PR a while back and had to some different minor versions as old ones had their repos taken down. https://github.com/stevensonmt/libgraph/pull/1 adjusts the github workflow to explicitly reference some OTP / elixir versions that I could find pullable repos for.

zblanco avatar Sep 24 '25 19:09 zblanco