DevDefined.OAuth icon indicating copy to clipboard operation
DevDefined.OAuth copied to clipboard

OAuth Authorization header is not urldecoded.

Open bittercoder opened this issue 15 years ago • 2 comments

What steps will reproduce the problem?

  1. use oauth with header based authentication
  2. characters at the provider side are not urldecoded

What is the expected output? What do you see instead? exception that the oauth_verifier is rejected, while the different is because of the missing decoding

What version of the product are you using? On what operating system?

Please provide any additional information below. See the attachment which is a patch to fix this issue.

Reported by: http://code.google.com/u/avkekem/

Originally logged on google code here: http://code.google.com/p/devdefined-tools/issues/detail?id=9

A patch is included here:

http://devdefined-tools.googlecode.com/issues/attachment?aid=3384463087779190539&name=patchUrlDecode.diff&token=e904dc9ca8c8151ec20d109e214e4f33

bittercoder avatar Aug 03 '10 20:08 bittercoder

Hi, I think I've hit the same issue. When used Auth headers I always get rejection from the other party and I think it's the same encoding issue. However the patch you attach does not seem to exist. Can anyone point me in the right direction on how to get this bug fixed? Thanks, Corneliu

corneliutusnea avatar Jul 13 '11 06:07 corneliutusnea

That patch is here - I think google code has just changed the link:

http://code.google.com/p/devdefined-tools/issues/attachmentText?id=9&aid=3384463087779190539&name=patchUrlDecode.diff&token=831720cbd6d42e9c4afa9075c5fe8b37

I haven't had a chance to review it yet - but if you feel like implementing a patch and providing a pull request, be happy to apply it.

bittercoder avatar Jul 13 '11 12:07 bittercoder

Closed, library no longer supported.

bittercoder avatar Nov 02 '23 22:11 bittercoder