go-bitsong icon indicating copy to clipboard operation
go-bitsong copied to clipboard

Normal NFT

Open giorgionocera opened this issue 3 years ago • 4 comments

In the nft module, which is the difference between a normal NFT (MasterEdition equal to nil) and an NFT with MasterEdition and MaxSupply = 1? I think the two represent exactly the same object since both of them have an NFT and no one can create other prints. So, why there is the possibility to generate two different versions for the same kind of object? This could generate inconsistencies. What do you think about it?

giorgionocera avatar Sep 30 '22 08:09 giorgionocera

It's because of struct we have, do you like to make it to be consistent to have MaxSupply=1 for normal NFT?

ryusmo avatar Sep 30 '22 17:09 ryusmo

IMHO, it is a way to make it more consistent. But I ask you and @angelorc if you agree with me.

giorgionocera avatar Sep 30 '22 17:09 giorgionocera

@angelorc agrees on making them more consistent.

giorgionocera avatar Oct 06 '22 07:10 giorgionocera

In this way, we can use only the maxSupply as an argument in input for the messages, instead of passing the whole masterEdition.

giorgionocera avatar Oct 11 '22 07:10 giorgionocera