bitcore-message

bitcore-message copied to clipboard

Allow Message to be initialized with a Buffer

3

Similar to #5, except that the message itself is allowed to be a Buffer.

bgok

breaks if you use this with bitcore-lib-cash

1

If you use this with bitcore-lib-cash you will get issues when trying to sign. In particular ``` throw new errors.InvalidArgument(argumentName, message, docsPath); ^ Invalid Argument: First argument should be an...

brad1121

[REQ] Add Segwit Sign/Verify support

1

[Bitcoin issue 10542](https://github.com/bitcoin/bitcoin/issues/10542#issuecomment-352534442) discusses how to expand the current sign/verify functionality to include Segwit. The basic idea is to expand the header byte to help identify the segwit address scheme...

brianddk

Error: More than one instance of bitcore-lib found. Please make sure to require bitcore-lib and check that submodules do not also include their own bitcore-lib dependency.

1

These 2 things dont want to work together: ``` var bitcore = require('bitcore-lib'); var Message = require('bitcore-message'); ``` https://github.com/bitpay/bitcore-lib/issues/153

gkucmierz

Use bitcore-lib as a peerDependency

6

One wrinkle to using the bitcore stack is the obvious need to have a singleton `bitcore-lib`. The `bitcoin-lib` package hosts the `bitcoind` library and there are good reasons to not...

CaptEmulation

broken image link at top of readme

2

image is trying to fetch from: http://bitcore.io/css/images/module-message.png but gets 404

harlantwood

Solving all "include guard" headaches: https://github.com/bitpay/bitcore-lib/issues/21

levino

braydonf

Message methods should accept more argument types

4

For example, `sign` could check if privateKey is a String or Buffer and convert accordingly. I can add these, but I'll wait for #2 to be merged to avoid any...

trevinhofmann

``` undefined > Message('hello, world').verify("bc1pydpj45r52e5njm4j7apj3sycjnaugl5znprkph9y676lv9ad0zsq4785ga", "ILtDggv+4LT25kBsbqeZ72X1AdvZ4d43pEOlrTVXEU8tdZUoRCvIkyEN9hI0GX1NjsbvzHCS7kMHF9z9QL3jDhI="); Uncaught Error: Non-base58 character at Object.decode (/Users/a/Downloads/hardhat/node_modules/bitcore-lib/node_modules/bs58/lib/bs58.js:51:37) at Base58.decode (/Users/a/Downloads/hardhat/node_modules/bitcore-lib/lib/encoding/base58.js:48:26) at Base58Check.decode (/Users/a/Downloads/hardhat/node_modules/bitcore-lib/lib/encoding/base58check.js:45:31) at Address._transformString (/Users/a/Downloads/hardhat/node_modules/bitcore-lib/lib/address.js:279:35) at Address.fromString (/Users/a/Downloads/hardhat/node_modules/bitcore-lib/lib/address.js:379:22) at Message.verify (/Users/a/Downloads/hardhat/node_modules/bitcore-message/lib/message.js:90:30) > >...

phpmac