bitcore-lib

bitcore-lib copied to clipboard

When signing a transaction, add an attempt to sign if address corresponds to the uncompressed public key

1

Original issue: https://github.com/bitpay/bitcore/issues/1072

braydonf

BUG: Address strips out trailing spaces from an address string

1

https://github.com/bitpay/bitcore-lib/blob/master/lib/address.js#L278 trims trailing whitespace from the address string. This is not strict validation. Spaces are not valid characters in an address. Code relying on bitcore-lib to validate an address need...

gabegattis

Remove HDKeyCache

1

braydonf

Throw when invalid network string is passed in

1

In some cases, we pass in a network as a string to specify the network of some other argument. An example is creating an address ``` javascript var bitcore =...

gabegattis

Currently the dust check uses a fixed amount, and should be based on the size of the transaction, see: https://github.com/bitcoin/bitcoin/blob/0.12/src/primitives/transaction.h#L160-L175 Relevant code in bitcore-lib: https://github.com/bitpay/bitcore-lib/blob/master/lib/transaction/transaction.js#L250-L261 Reported issue: https://github.com/bitpay/copay/issues/4343

braydonf

secp256k1-node instead elliptic

5

[secp256k1-node](http://github.com/cryptocoinjs/secp256k1-node) uses bindings to [bitcoin/secp256k1](http://github.com/bitcoin/secp256k1) in node.js and [elliptic](http://github.com/indutny/elliptic) (right now) in browser as fallback, available with same interface. Since v3.0.0 was released, `bitcore-lib` could use this package for secp256k1...

fanatid

BlockHeader prevHash value

3

1. The `prevHash` value for the genesis block will be `"0000000000000000000000000000000000000000000000000000000000000000"` from the `toObject()` method. 2. The `prevHash` is a LE buffer, e.g. `"43497fd7f826957108f4a30fd9cec3aeba79972084e90ead01ea330900000000"` instead of `"000000000933ea01ad0ee984209779baaec3ced90fa3f408719526f8d77f4943"`

braydonf

Generated private key is 31 bytes instead of 32.

2

The derived() function sometimes returns 31 byte keys. In the `derive()` function here: https://github.com/bitpay/bitcore-lib/blob/master/lib/hdprivatekey.js#L194 there is clearly the intention of having the Buffer padded to 32 bytes. But when testing...

coder5876

- https://github.com/indutny/elliptic (6.2.8) - https://github.com/indutny/bn.js (4.11.4) There are API changes in the recent versions that need to be handled. Original issue: https://github.com/bitpay/bitcore/issues/1327

braydonf

It seems that the BIP32 derivation code (https://github.com/bitpay/bitcore-lib/blob/master/lib/hdprivatekey.js#L193) doesn't do any checks against the validity of the generated private key. https://github.com/bitcoin/bips/blob/master/bip-0032.mediawiki#private-parent-key--private-child-key: > In case parse256(IL) ≥ n or ki =...

axic