containers icon indicating copy to clipboard operation
containers copied to clipboard

[bitnami/nginx] Add `envsubst` to nginx

Open djschny opened this issue 2 years ago • 6 comments

Description of the change

Addresses #34957

Benefits

Documented in associated issue.

Possible drawbacks

Documented in associated issue.

Applicable issues

Fixes #34957

Additional information

djschny avatar Jan 25 '24 19:01 djschny

Switching from draft to regular PR to see if builds will run.

djschny avatar Jan 25 '24 19:01 djschny

Hi!

Thank you so much for the PR. The verification is not being triggered because of this

Changes should affect to only one asset. You are currently modifying: kubectl nginx

Could you split the PR for kubectl and nginx?

javsalgar avatar Jan 26 '24 08:01 javsalgar

Could you split the PR for kubectl and nginx?

Sure, sorry didn't realize that.

djschny avatar Jan 26 '24 11:01 djschny

@javsalgar all fixed, should be good to go now on this one, will open a second PR.

djschny avatar Jan 26 '24 12:01 djschny

Hi @djschny,

As mentioned in #55365 , we have created an internal task to evaluate the gettext-base package addition in all distributions in which we provide NGINX images as part of Tanzu Application Catalog. We will keep you posted.

In the meantime, please extend our image with the required packages on your side.

gongomgra avatar Jan 31 '24 16:01 gongomgra

Requested changes done.

djschny avatar Feb 20 '24 23:02 djschny

@gongomgra is there anything else I need to change to get this moving?

djschny avatar Apr 01 '24 12:04 djschny

Hi @djschny,

Sorry for the delay. I have been checking this and I have found we are adding the gettext package instead of gettext-base in other images like appsmith. Can you please update your PR? I don't have any other suggestion/requirement to this.

gongomgra avatar Apr 02 '24 07:04 gongomgra

Sorry @djschny, I have just noticed your changes are for an old version of the Dockerfiles based on debian-11, but we have recently updated the base image to debian-12. I have added the gettext package for the next image revision, so I'm closing this PR. Sorry for the inconveniences.

gongomgra avatar Apr 02 '24 08:04 gongomgra