charts icon indicating copy to clipboard operation
charts copied to clipboard

[bitnami/redmine] External MariaDB secret name is wrong fixes #12384

Open LedAlex opened this issue 3 years ago • 6 comments

Description of the change

Benefits

Possible drawbacks

Applicable issues

  • fixes #12384

Additional information

Checklist

  • [ ] Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • [ ] Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • [ ] Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • [ ] All commits signed off and in agreement of Developer Certificate of Origin (DCO)

LedAlex avatar Sep 12 '22 22:09 LedAlex

Hi!

Thank you so much for the PR! Could you fix the issues in the checks?

javsalgar avatar Sep 13 '22 08:09 javsalgar

Can someone merge this?

LedAlex avatar Sep 19 '22 22:09 LedAlex

Hi,

Thank you so much for the PR! It seems there is an issue with the branch, as it is affecting multiple files, could you fix it?

javsalgar avatar Sep 21 '22 09:09 javsalgar

Hi,

Thank you so much for the PR! It seems there is an issue with the branch, as it is affecting multiple files, could you fix it?

What do you mean "affecting multiple files"? I've changed only two files, helpers and version in chart, all the rest made by your bot in ci/cd.

LedAlex avatar Sep 21 '22 09:09 LedAlex

The PR shows a substantial amount of files changed

image

Also, I can see merge issues as well.

javsalgar avatar Sep 21 '22 09:09 javsalgar

The PR shows a substantial amount of files changed

image

Also, I can see merge issues as well.

If you check that files, you'll see that I'm not the author of these changes. Either bitnami-bot or someone else. I don't know why they appeared in PR after first CI\CD checks fail and I don't know how to solve it (maybe only new branch and PR).

LedAlex avatar Sep 21 '22 10:09 LedAlex

The issue is that your fork is not synchronized with upstream

image

This should help you: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

javsalgar avatar Sep 22 '22 07:09 javsalgar