estela icon indicating copy to clipboard operation
estela copied to clipboard

estela-web: Automatically try to add arguments, env vars, and tags written in creation forms

Open raymond1242 opened this issue 2 years ago • 1 comments

Description

estela-web: Automatically try to add arguments, env vars, and tags written in creation forms

Issue

* Github Issue ID.

Checklist before requesting a review

  • [x] I have performed a self-review of my code.
  • [x] My code follows the style guidelines of this project.
  • [x] New and existing tests pass locally with my changes.
  • [x] I have made corresponding changes to the documentation.
  • [x] If this change is a core feature, I have added thorough tests.
  • [x] If this change affects or depends on the behavior of other estela repositories, I have created pull requests with the relevant changes in the affected repositories. Please, refer to our official documentation.
  • [x] I understand that my pull request may be closed if it becomes obvious or I did not perform all of the steps above.

raymond1242 avatar Aug 27 '23 23:08 raymond1242

@raymond1242 I have added a change refactoring some of the code. We still need to add this functionality to the clone modals.

Also, ensure that we verify both cases correctly when the name is present but the value isn't and vice-versa. I fixed it for the create modals because if I had an argument/env var name: it would raise an error but :value would create the job without verifying this is not a valid argument/env var.

Done @mgonnav

raymond1242 avatar Sep 27 '23 13:09 raymond1242