dablooms

dablooms copied to clipboard

also removed unneeded spaces.

henninb

Added default value for named parameters, checks for parameter values, reporting for errors and fixed segmentation fault when object creation fails

2

martinthomas

free the file handle

2

By press testing,I find the program crashed because of the file handlers beyond the limit.

gptcod

Cant build

2

undefined reference to `pow` it seems to be a problem with the linking and the math lib

Alonzo-Coeus

There is a serious error in free_counting_bloom, and memory leak will happen. Please modify the code as follows: don't free bloom->bitmap directly. call free_bitmap( bloom->bitmap ) instead. // int free_counting_bloom(counting_bloom_t...

wsm234

... and also, this repo is unmaintained (I left the bitly org and lost push privileges) but I've pushed up a fix to https://github.com/ploxiln/dablooms ( https://github.com/ploxiln/dablooms/commit/a9cc8567be85ae88fdf361d9f351ff29dad122b2 )

ploxiln

In the paper referenced for the bloom filter hashing algorithm used (https://github.com/bitly/dablooms/blob/master/src/dablooms.c#L185) (Kirsch, Mitzenmacher [2006]) - the recommended algorithm is given by: gi(x)=h1(x)+ih2(x)(mod p) From my reading it seems that...

pik

Can't delete Go bloom filter

1

Is there currently no way to delete a Go bloom filter? https://github.com/bitly/dablooms/blob/master/godablooms/dablooms.go#L44 Am I also correct in thinking this memory will never get GC'ed, because it's in C?

JakeAustwick

Invalid keyword arguments to pydablooms segfaults

1

If I initialize a new dabloom filter with the incorrect keyword arguments, I get a segfault: ``` >>> b = pydablooms.Dablooms(capactiy=1000, error_rate=0.05, filepath='/tmp/bloom.bin') Segmentation fault: 11 ``` The segfault happens...

mynameisfiber