icsx5 icon indicating copy to clipboard operation
icsx5 copied to clipboard

Donation dialog does not show button on standard

Open ArnyminerZ opened this issue 1 year ago • 3 comments

Purpose

The ose version of ICSx5 shows a donation dialog every once in a while, which does have a correct working donation button, but once you hide it, it doesn't pop up again, and can't be invoked in any other way. If the one in the info activity is pressed, the same is shown both in gplay and standard, which doesn't contain any donation button to comply with Google Play's policy.

This dialog should be the same as the one that pops up automatically in standard.

Short description

The preferences have been migrated to DataStore since otherwise there's no easy way to access them from outside the DonateDialogService for example.

There's a migration function in SubscriptionsModel even though I don't think it's even worth it for what it migrates.

Now in InfoActivity the services (ComposableStartupService) are also initialized. If there's a service with the FLAG_DONATION_DIALOG it's shown instead of the default "text dialog".

[!NOTE] If we eventually migrate to Compose Navigation services won't be needed to be initialized twice since there would be only one Activity.

Maybe the migration to DataStore is not mandatory for this fix, but I think it's useful, and may solve any future issues.

Checklist

  • [x] The PR has a proper title, description and label.
  • [x] I have self-reviewed the PR.
  • [x] I have added documentation to complex functions and functions that can be used by other modules.
  • [x] I have added reasonable tests or consciously decided to not add tests.

ArnyminerZ avatar Jul 23 '24 16:07 ArnyminerZ

Nevermind, Ricki says it's nice to try out here in ICSx5 already and should not cause complications when incorporating into DAVx5 :)

Perfect. In any case, there isn't much stored there, so really shouldn't matter for migration to DAVx5

ArnyminerZ avatar Jul 30 '24 13:07 ArnyminerZ

Aaaand now tests are failing

ArnyminerZ avatar Jul 31 '24 13:07 ArnyminerZ

Should be ready :)

ArnyminerZ avatar Aug 01 '24 18:08 ArnyminerZ

Somethings seems to not work with the CI emulator tests, but the change is little. Looks good :)

sunkup avatar Aug 05 '24 14:08 sunkup