sshkit.ex icon indicating copy to clipboard operation
sshkit.ex copied to clipboard

Attempt to handle missing pattern match

Open CharlesOkwuagwu opened this issue 5 years ago • 1 comments

Attempt to handle missing function call on {:data, _, n, data}

Description

Motivation and Context

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [ ] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my changes (with unit and/or functional tests).
  • [ ] I have added a note to CHANGELOG.md if necessary (in the ## master section).

CharlesOkwuagwu avatar Jul 30 '20 08:07 CharlesOkwuagwu

Hey @CharlesOkwuagwu 👋

Thanks for jumping onto this 🙏 . I suppose this is fixing the issue you ran into in #158 , right?

Could you give us a bit more context on why this change is fixing the issue for you? It would also be super nice if you could add a test scenario for this new code path and describe the change in the changelog. We can of course help you with both 👯.

klappradla avatar Oct 14 '20 16:10 klappradla