bdk icon indicating copy to clipboard operation
bdk copied to clipboard

The `CanonicalIter` should return the `TxNode`'s.

Open oleonardolima opened this issue 4 months ago • 4 comments

I'll create an issue to address this one in a follow-up PR.

Originally posted by @oleonardolima in https://github.com/bitcoindevkit/bdk/pull/2029#discussion_r2386483114

oleonardolima avatar Sep 29 '25 01:09 oleonardolima

Hi, I would like to work on this issue. I plan to update CanonicalIter to return TxNode instead of Transaction and adjust affected call sites. Shall i take that

Rahamath-unnisa avatar Oct 08 '25 11:10 Rahamath-unnisa

Thanks for the interest! You can start working on this one, but you'll face a lot of rebase after the new API get's merged #2038, so I'd recommend choosing another one for now.

oleonardolima avatar Oct 09 '25 03:10 oleonardolima

Hi, I've completed the work on this issue and submitted a pull request: #2062 https://github.com/bitcoindevkit/bdk/pull/2062. I'm aware that the new API (#2038) is pending, which might require rebasing. Please let me know if you'd prefer me to focus on another issue in the meantime. Thanks for your guidance!

On Thu, 9 Oct 2025 at 08:51, Leonardo L. @.***> wrote:

oleonardolima left a comment (bitcoindevkit/bdk#2051) https://github.com/bitcoindevkit/bdk/issues/2051#issuecomment-3383907107

Thanks for the interest! You can start working on this one, but you'll face a lot of rebase after the new API get's merged #2038 https://github.com/bitcoindevkit/bdk/pull/2038, so I'd recommend choosing another one for now.

— Reply to this email directly, view it on GitHub https://github.com/bitcoindevkit/bdk/issues/2051#issuecomment-3383907107, or unsubscribe https://github.com/notifications/unsubscribe-auth/BRHYZRTETK53CJVEC2TVBEL3WXIERAVCNFSM6AAAAACHXURDKWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGOBTHEYDOMJQG4 . You are receiving this because you commented.Message ID: @.***>

Rahamath-unnisa avatar Oct 09 '25 07:10 Rahamath-unnisa

Hi! Thanks again for the earlier feedback — I’ve submitted a new PR that directly addresses the type-level refactor: #2063. It replaces the (txid, tx, reason) tuple with a scoped CanonicalTxNode<A> struct, without changing the behavior of the canonicalization algorithm. The iterator now yields full node objects, and downstream usage has been updated accordingly. Let me know if any further changes are needed — happy to iterate!

Rahamath-unnisa avatar Oct 10 '25 17:10 Rahamath-unnisa