bdk-ffi icon indicating copy to clipboard operation
bdk-ffi copied to clipboard

Add finalize to Psbt

Open andreasgriffin opened this issue 1 year ago • 5 comments

Description

Add finalize() to Psbt. See https://github.com/bitcoindevkit/bdk-ffi/issues/469

Checklists

All Submissions:

  • [x] I've signed all my commits
  • [x] I followed the contribution guidelines
  • [x] I ran cargo fmt and cargo clippy before committing

New Features:

  • [ ] I've added tests for the new feature
  • [ ] I've added docs for the new feature

andreasgriffin avatar Jul 31 '24 19:07 andreasgriffin

@thunderbiscuit : Do you know how to solve the electrum-client errors in the CI-tests?

andreasgriffin avatar Aug 18 '24 10:08 andreasgriffin

A rebase of this on master should solve your issues! We're finally ready to start merging new stuff. Feel free to rebase and I'll take a look today/tomorrow.

thunderbiscuit avatar Aug 29 '24 17:08 thunderbiscuit

@thunderbiscuit : Could you take a look if it is ready to be merged?

andreasgriffin avatar Sep 05 '24 17:09 andreasgriffin

You'll want to squash this into a single commit by using git rebase -i HEAD~5 and changing pick to squash. You will also want to rename your commit message using conventional commits. Although, I am afraid this work may also be in vein as adding PSBT to bitcoin-ffi is planned here. If I pick up PSBT as a type to add I will be sure to include finalize

rustaceanrob avatar Sep 13 '24 20:09 rustaceanrob

If I pick up PSBT as a type to add I will be sure to include finalize

Great!

andreasgriffin avatar Sep 14 '24 08:09 andreasgriffin

#630 closes this. Thanks @andreasgriffin

rustaceanrob avatar Nov 21 '24 19:11 rustaceanrob