bdk-cli icon indicating copy to clipboard operation
bdk-cli copied to clipboard

Added validate_domain in electrum option

Open Rahamath-unnisa opened this issue 3 months ago • 2 comments

Description: This PR adds the validate_domain option to the Electrum client in bdk-cli. This resolves #134 . Changes included:

Added --validate-domain flag in command.rs.

Updated Electrum client handling in handlers.rs and utils.rs to respect the flag.

Verified functionality locally using:

RUST_LOG=debug,rusqlite=info,rustls=info cargo run --features electrum -- wallet --client-type electrum --database-type sqlite --url ssl://electrum.blockstream.info:60002 --validate-domain true --ext-descriptor "wpkh(.../*)" sync

Motivation: Allows users to enable or disable domain validation for Electrum servers, useful for self-hosted/custom servers while preserving security by default.

Checklist:

Tested locally with Electrum client

No unrelated changes included

Rahamath-unnisa avatar Oct 20 '25 15:10 Rahamath-unnisa

@Rahamath-unnisa pls mention in PR description that this resolves https://github.com/bitcoindevkit/bdk-cli/issues/134.

va-an avatar Oct 21 '25 08:10 va-an

Hi @110CodingP, I have made the requested cleanups in commands.rs and handlers.rs per your review comments All changes are pushed to the validate_domain-config branch. Please let me know if anything else is needed. Thanks!

Rahamath-unnisa avatar Oct 23 '25 11:10 Rahamath-unnisa