bdk-cli icon indicating copy to clipboard operation
bdk-cli copied to clipboard

Add `validate_domain` Electrum option

Open rajarshimaitra opened this issue 3 years ago • 5 comments

Since https://github.com/bitcoindevkit/bdk/commit/8d4cc3920ab4177fd0f3916155671b1067285eda bdk opens the validate_domain option in electrum config. We should also expose it via bdk-cli electrum options.

rajarshimaitra avatar Dec 29 '22 06:12 rajarshimaitra

Hi! 👋 I’d like to work on this issue and expose the validate_domain option in bdk-cli for Electrum. Could I take this up?

Rahamath-unnisa avatar Oct 09 '25 13:10 Rahamath-unnisa

Hi! 👋 I’d like to work on this issue and expose the validate_domain option in bdk-cli for Electrum. Could I take this up?

Yes, you can

tvpeter avatar Oct 09 '25 13:10 tvpeter

Hi Peter,

Thanks for assigning me to #134! I’m excited to work on adding the validate_domain option.

I wasn’t able to locate the CLI file (electrum.rs or similar) in the repo. Could you point me to where it is, or how I can find it?

Thanks a lot! Rahamath

On Thu, 9 Oct 2025 at 18:55, Peter Tyonum @.***> wrote:

Assigned #134 https://github.com/bitcoindevkit/bdk-cli/issues/134 to @Rahamath-unnisa https://github.com/Rahamath-unnisa.

— Reply to this email directly, view it on GitHub https://github.com/bitcoindevkit/bdk-cli/issues/134#event-20185591903, or unsubscribe https://github.com/notifications/unsubscribe-auth/BRHYZRV5A2FKGJ6HSCLQW4L3WZO3JAVCNFSM6AAAAACIXO4YRKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRQGE4DKNJZGE4TAMY . You are receiving this because you were assigned.Message ID: @.***>

Rahamath-unnisa avatar Oct 09 '25 13:10 Rahamath-unnisa

I wasn’t able to locate the CLI file (electrum.rs or similar) in the repo. Could you point me to where it is, or how I can find it?

Hello Rahamath, It’s essential to understand the project before seeking to take on an issue. Please review our contribution guidelines for first timers here. In the meantime, I will unassign the issue. Thank you.

tvpeter avatar Oct 09 '25 17:10 tvpeter

Hi 👋,

I’ve studied the codebase and the contribution guidelines, made the necessary modifications to expose the validate_domain option in bdk-cli, and tested it locally. Here is the Pull Request: PR #223 Looking forward to your review! Thanks

Rahamath-unnisa avatar Oct 20 '25 15:10 Rahamath-unnisa