bitcoin-core
Add Import to Wallet GUI
This PR does a few things
- Refactors importmulti and importdescripters RPC code
- Adds functions to interfaces
- Adds GUI's for importpubkey, importprivkey, importaddress, importmulti, and importdescriptors RPCs
The dialogs are located under File -> Import to Wallet... The options vary based on what is supported with your specific wallet type.
| Dialogs are Located | Import Public Key Dialog |
|---|---|
 |
 |
| Import Private Key Dialog | Import Address Dialog |
|---|---|
 |
 |
| Import Multi Dialog scriptPubKey Tab | Import Multi Dialog Descriptor Tab |
|---|---|
 |
 |
| Import Descriptors Dialog |
|---|
 |
For Range before I had a lineedit with placeholders begin and end, @achow101 suggested I used QSpinBox, but it doesn't have placeholder text. So Currently if both are default value it counts as no input. It would look very nice if I implemented a custom QAbstractSpinBox with placeholder text, but I am not sure if it is overkill for this PR.
Concept ACK. Perhaps it would be better to split each menu item into its own PR.
@KolbyML
It is not an appropriate usage of CI resources to debug your branch.
@KolbyML
It is not an appropriate usage of CI resources to debug your branch.
@hebasto oh, sorry for doing that. How should I debug the Win64 native [vs2022] linker error I have then going forward? Thank you for letting me know
How should I debug the Win64 native [vs2022] linker error I have then going forward? Thank you for letting me know
bitcoin/bitcoin#25929 should fix it
How should I debug the Win64 native [vs2022] linker error I have then going forward? Thank you for letting me know
bitcoin/bitcoin#25929 should fix it
Thank you for letting me know that was driving me crazy. Cause it seemed like my code was fine. I will push my changes, then switch the PR to a draft then, since I think that won't trigger CI. Worse comes to worse I will just work on a local branch like I was originally before working on the PR.
Edit: switch it to a draft till I am done implementing tests for importmulti/importdescriptors
Edit: switch it to a draft till I am done implementing tests for importmulti/importdescriptors
Just click "Convert to draft" :)
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #bitcoin/bitcoin/26238 (clang-tidy: fixup named argument comments by fanquake)
- #bitcoin/bitcoin/26186 (rpc: Sanitize label name in various RPCs with tests by aureleoules)
- #bitcoin/bitcoin/22838 (descriptors: Be able to specify change and receiving in a single descriptor string by achow101)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
