gui icon indicating copy to clipboard operation
gui copied to clipboard

Make network graph slider easier to use

Open rebroad opened this issue 4 years ago • 5 comments

Currently the network graph slider has 288 possible positions, and most of these are likely never used, due to obscure durations.

This pull request simplifies the slider to have only 12 positions, making it much easier to use, and setting the durations to more likely-wanted settings: 1m, 2m, 5m, 10m, 20m, 30m, 1h, 2h, 3h, 6h, 12h, 24h.

This change also allows easier rearranging of the window, for example, adding an extra button next to the reset button, shrinking the slider, and therefore making it still easy to use when smaller in length.

rebroad avatar Nov 25 '21 10:11 rebroad

Concept NAK, 12 sliders are too few positions for such a large slider.

I booted it and tested the 12 sliders. It feels like few positions. Please iterate.

katesalazar avatar Nov 27 '21 23:11 katesalazar

Concept NAK, 12 sliders are too few positions for such a large slider.

I booted it and tested the 12 sliders. It feels like few positions. Please iterate.

@katesalazar This is intentional as there is talk about adding an extra button, and so the slider will be reduced in size in the future, but I do agree with you as it is.

What extra durations do you propose being added? I propose 1-10 in steps of 1, 10-60 in steps of 5, 1hr to 2hr in steps of 0.5hrs, 2hr to 6hr in steps of 1hr, 6hrs to 24hrs in steps of 3hrs. That's a total of 10+10+2+4+3 = 29 steps.

or 1,2,3,5,10,15,20,30,1h,2h,3h,6h,12h,18h,24h ? I really question whether people want 6,7,8,9,25,35,45,50,55,1.5h,4h,5h,9h,15h,21h... these seem unlikely to be used.

rebroad avatar Dec 07 '21 11:12 rebroad

How exactly does this make the slider "easier to use"? The workflow of using the slider as a slider remains untouched

@jarolrod because it is faster to use, i.e. less moving left and right to get the exact duration desired (usually a round number).

rebroad avatar Dec 07 '21 11:12 rebroad

nice, looking forward to the button

On Tue, Dec 7, 2021 at 12:49 PM Rebroad @.***> wrote:

Concept NAK, 12 sliders are too few positions for such a large slider.

I booted it and tested the 12 sliders. It feels like few positions. Please iterate.

This is intentional as there is talk about adding an extra button, and so the slider will be reduced in size in the future, but I do agree with you as it is.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bitcoin-core/gui/pull/483#issuecomment-987852952, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMRS4W674BMU6YHNH2MBLSDUPXYGDANCNFSM5IYHJOAQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

katesalazar avatar Dec 10 '21 20:12 katesalazar

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

DrahtBot avatar Feb 25 '22 05:02 DrahtBot