gui icon indicating copy to clipboard operation
gui copied to clipboard

Enable a non-linear network traffic option (click to toggle between linear and non-linear)

Open rebroad opened this issue 4 years ago • 11 comments

Helps to make visible the low bandwidth traffic and high bandwidth (or spikes) concurrently. (Previously the low bandwidth traffic becomes invisible in the presence of spikes).

Old format: image

New format: image

Old format: image

New format: image

(clicking on the graph will toggle between the new format and the old format).

rebroad avatar Nov 15 '21 17:11 rebroad

Love the idea, the problem with these things is there's gonna be someone who is annoyed by the behavior change.

When I do things like this, I always maintain the old behavior somehow, so that kind of reaction against gets suppressed more easily.

katesalazar avatar Nov 15 '21 21:11 katesalazar

Concept ACK, this seems like a good idea to me, given that, what you really want to see in graphs like this is the gross magnitude and not so much very small variations in the throughput.

laanwj avatar Nov 16 '21 10:11 laanwj

Love the idea, the problem with these things is there's gonna be someone who is annoyed by the behavior change.

When I do things like this, I always maintain the old behavior somehow, so that kind of reaction against gets suppressed more easily.

I agree, which is why I've now (latest commit) made it toggleable - just click on the graph to switch between the two display options.

rebroad avatar Nov 19 '21 18:11 rebroad

Concept ACK.

Love the idea, the problem with these things is there's gonna be someone who is annoyed by the behavior change. When I do things like this, I always maintain the old behavior somehow, so that kind of reaction against gets suppressed more easily.

I agree, which is why I've now (latest commit) made it toggleable - just click on the graph to switch between the two display options.

Obscure, but OK.

katesalazar avatar Nov 19 '21 21:11 katesalazar

Concept ACK.

hebasto avatar Nov 21 '21 20:11 hebasto

Concept ACK

More useful information "at a glance".

RandyMcMillan avatar Nov 27 '21 23:11 RandyMcMillan

Adding a label to the highest horizontal line would be useful.

RandyMcMillan avatar Nov 28 '21 00:11 RandyMcMillan

Adding a label to the highest horizontal line would be useful.

I did consider this, but as it's not the current functionality, and it would make the highest point on the graph no longer reach the top (as the label would need extra space) I decided against it. Could be done as a separate pull request though.

rebroad avatar Nov 28 '21 16:11 rebroad

Adding a label to the highest horizontal line would be useful.

@RandyMcMillan #492 also reduces the need for this as now you can point to a point on the graph to get details.

e.g. image (displays time in the same format as in the debug,log so also makes it easy to find the corresponding point in the log file).

rebroad avatar Dec 06 '21 16:12 rebroad

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

DrahtBot avatar Dec 30 '21 10:12 DrahtBot

@rebroad - added this in PR https://github.com/bitcoin-core/gui/pull/539

https://github.com/bitcoin-core/gui/pull/539/commits/10f8e797bcd6d8f8910b7560a6e132d197b5f97b

Screen Shot 2022-01-29 at 2 10 01 PM (2)

NOTE: I was careful to preserve commit authorship attribution: 👍🏽 https://github.com/bitcoin-core/gui/pull/539/commits

RandyMcMillan avatar Jan 28 '22 18:01 RandyMcMillan

Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened.

hebasto avatar Oct 26 '22 15:10 hebasto