R[v22.0] Application icon

[Willtech]

Build v22.0 on Fedora 34 with Berkley DB 4.8 (note Fedora people, despite newer versions being available Berkley DB 4.8 IS the standard as it is bug free and fully compatible.)it looks like the build is missing the application icon and is showing with the default shell executable file icon.

Also for whoever works on the application, the Berkley DB copyright/licence information is missing from About Bitcoin Core modal window.

The Berkley DB copyright/licence information has to be there all the places wherever it was before.

Don't anyone even try and tell me it is not a GUI bug if anyone has to look at it on their screen.

[Willtech]

[Willtech]

If it is helpful to see what I am building just cd bitcoin/ and run makebitcoin.sh I also run strip. I also ln -s dnf get https://github.com/Willtech/bitcoin/tree/v0.22.0rc4

[hebasto]

I can confirm a bug with the wrong app icon when running in Wayland:

[hebasto@localhost bitcoin]$ src/qt/bitcoin-qt -signet -printtoconsole -debug=qt
QSocketNotifier: Can only be used with threads started with QThread
2021-09-29T13:16:45Z Bitcoin Core version v22.99.0-d648bbb0a790 (release build)
2021-09-29T13:16:45Z Qt 5.15.2 (dynamic), plugin=wayland (dynamic)
2021-09-29T13:16:45Z No static plugins.
2021-09-29T13:16:45Z Style: adwaita / Adwaita::Style
2021-09-29T13:16:45Z System: Fedora 34 (Workstation Edition), x86_64-little_endian-lp64
...

Everything is ok when QT_QPA_PLATFORM=xcb:

[hebasto@localhost bitcoin]$ QT_QPA_PLATFORM=xcb src/qt/bitcoin-qt -signet -printtoconsole -debug=qt
2021-09-29T13:17:37Z Bitcoin Core version v22.99.0-d648bbb0a790 (release build)
2021-09-29T13:17:37Z Qt 5.15.2 (dynamic), plugin=xcb (dynamic)
2021-09-29T13:17:37Z No static plugins.
2021-09-29T13:17:37Z Style: adwaita / Adwaita::Style
2021-09-29T13:17:37Z System: Fedora 34 (Workstation Edition), x86_64-little_endian-lp64

@Willtech

Build v22.0 on Fedora 34 with Berkley DB 4.8 (note Fedora people, despite newer versions being available Berkley DB 4.8 IS the standard as it is bug free and fully compatible.)it looks like the build is missing the application icon and is showing with the default shell executable file icon.

Also for whoever works on the application, the Berkley DB copyright/licence information is missing from About Bitcoin Core modal window.

The Berkley DB copyright/licence information has to be there all the places wherever it was before.

Don't anyone even try and tell me it is not a GUI bug if anyone has to look at it on their screen.

Could you keep the OP focused on the reported bug only which is mentioned in the issue title?

[hebasto]

A similar bug in other project: https://bugs.documentfoundation.org/show_bug.cgi?id=125934

Also from https://blog.martin-graesslin.com/blog/2015/07/porting-qt-applications-to-wayland/:

On X11 the applications exported the window icon as pixmap data. This is no longer possible on Wayland. Instead the compositor maps the window icon from the desktop file and the application announces the desktop file for a window. In Qt this is done by using the reverse domain name combined with the binary name.