bitauth-ide icon indicating copy to clipboard operation
bitauth-ide copied to clipboard

Hide stack visualization for fully-unexecuted evaluations

Open bitjson opened this issue 5 years ago • 2 comments

While all evaluations occur during compilation, we can safely hide the internal stack visualization for evaluations which result in bytecode which is never executed. E.g. the stack visualization (current_block_time delay_seconds ...) for the evaluation in this locking script should be hidden since it's not relevant for the active unlocking script: Screen Shot 2020-07-28 at 8 59 14 AM

bitjson avatar Jul 28 '20 16:07 bitjson

Related: we should continue to show the stack visualization for internal evaluations even if their parent script is failing to compile. (Often, the internal evaluation being incorrect is the root cause of the outer compilation failure, but it's tedious to debug without a stack visualization for the internal evaluation.)

bitjson avatar Sep 26 '23 16:09 bitjson

Also related: there was a regression between https://github.com/bitauth/bitauth-ide/commit/1846ad107812280575c6df5a314d4a38ba543006 (deployed) and https://github.com/bitauth/bitauth-ide/commit/cd8c0a0288068199921b143263792a43d83a31e8 (deployed) in which spacers for lines ending inside internal evaluation are no longer nested within the spacers of the parent evaluation.

E.g. before:

Screenshot 2024-06-25 at 4 47 50 PM

After:

Screenshot 2024-06-25 at 4 45 18 PM

bitjson avatar Jun 25 '24 20:06 bitjson