backintime icon indicating copy to clipboard operation
backintime copied to clipboard

GUI icons KDE Plasma compatibility fix suggestion

Open Sadi58 opened this issue 4 years ago • 1 comments

At the present Back In Time looks out of place under KDE Plasma 5. To fix this, the following 2 changes are required in ./qt/icon.py (installed as /usr/share/backintime/qt/icon.py).

  1. Insert 'breeze' between 'gnome' and 'oxygen' in line 19.
  2. Replace 'show-hidden' with 'view-hidden' in line 62. This last change (because Breeze icon theme has such an icon already) will then require changing all icon names under ./qt/icons from show-hidden.svg to view-hidden.svg (which are installed in hicolor icon theme action icons).

Sadi58 avatar May 12 '21 09:05 Sadi58

And Icons should work for HiDPI.

farion avatar Jun 05 '21 16:06 farion

I am not sure if the view-hidden.svg icon is always available in the desktops but should be installed by BiT (see #507)...

aryoda avatar Sep 09 '22 01:09 aryoda

@Sadi58 Very thoughtful proposal!

Could be fixed together with #1306

aryoda avatar Nov 24 '22 01:11 aryoda

And Icons should work for HiDPI.

@farion Did you observe problems with BiT on High DPI displays?

The High DPI settings of our underlying GUI framework Qt5 are described here

https://doc.qt.io/qt-5/highdpi.html

and in BiT at least the AA_EnableHighDpiScaling is activated by default:

https://github.com/bit-team/backintime/blob/3132f4dd4fc627aef46e152696f5b98fb3db0298/qt/qttools.py#L163-L165

aryoda avatar Nov 27 '22 12:11 aryoda

I have fixed all known issues (hopefully) with my PR #1480, re-testing and feed-back welcome!

https://github.com/bit-team/backintime/blob/535b1c7bfe04811dec06d1d2599135f373618222/qt/icon.py#L24

https://github.com/bit-team/backintime/blob/535b1c7bfe04811dec06d1d2599135f373618222/qt/icon.py#L95-L97

aryoda avatar Jul 17 '23 21:07 aryoda

I am closing this now as fixed and will be contained in the next release.

Please open a new issue in case of any problems.

aryoda avatar Sep 04 '23 19:09 aryoda