biscuit-java icon indicating copy to clipboard operation
biscuit-java copied to clipboard

Add ECDSA key support (SECP256R1)

Open itstheceo opened this issue 1 year ago • 4 comments

Uses BouncyCastle for the provider. ~~There are a few outstanding todos yet to be addressed, any pointers there~~ and feedback in general would be greatly appreciated. Thanks!

Screenshot 2024-05-24 at 11 47 57 AM

itstheceo avatar May 24 '24 02:05 itstheceo

https://github.com/biscuit-auth/biscuit-java/pull/104 is merged at last, and I tried to keep the conflict to a minimum, and have a similar API to what you used to sign the 3rd party blocks

Geal avatar Jun 25 '24 19:06 Geal

Updated and resolved the conflicts. Had some bumps with syncing upstream hopefully doesn't cause any issues. Would suggest squash merging this one, when it's satisfactory.

itstheceo avatar Jun 25 '24 23:06 itstheceo

@Geal rebased the remote signer branch as well, was a few touchpoints for the external signature handling which I've consolidated into the Signer class. Both branches passing again.

https://github.com/phocassoftware/biscuit-java/pull/2/files#diff-49f7203cf4239e61d6eb58b99a066338d08f58a1214b91c56959eab97b37cbcbR11-R49

itstheceo avatar Jun 26 '24 19:06 itstheceo

Great. Timing wise, we have to release the library with the public key interning fix and another fix that will come within a few days, in a minor version, then this will be merged with other API changes in a major version very soon

Geal avatar Jun 26 '24 21:06 Geal

Superseded by https://github.com/biscuit-auth/biscuit-java/pull/108

itstheceo avatar Nov 26 '24 18:11 itstheceo