biolink-model icon indicating copy to clipboard operation
biolink-model copied to clipboard

Missing enum for approval status

Open vdancik opened this issue 2 years ago • 3 comments

Describe the bug Missing enum for highest FDA approval status and drug regulatory status world wide

Expected behavior Restore FDAApprovalStatusEnum from a previous Biolink version or or define a new enumeration.

What working group (or team) did this request originate from? MolePro

vdancik avatar Feb 12 '24 18:02 vdancik

see also #869

nlharris avatar Feb 12 '24 18:02 nlharris

@vdancik - highest FDA approval status and drug regulatory status world wide are still their own slot in Biolink (have not changed). Do you want them to be part of a enum? I think the original intent was to save FDAApprovalStatusEnum for those statuses that were not the highest -- these two slots were to help "denormalize" the edge metadata to a chemical node for easier retrieval.

sierra-moxon avatar Mar 09 '24 01:03 sierra-moxon

Clarified at the DM call 03/28/24 - we would like an enumeration to constraint highest FDA approval status with a set of permissible values. drug regulatory status worldwide should have a similar permissible value enumeration.

The enum change was to accommodate "edge level" annotation; we might need a different PV set for this.

see: MaxResearchPhaseEnum (would have to add approval details to max research phase).
For discussion in chemical WG (@vdancik) - DM discussion was to have two properties on nodes similar to edges.

sierra-moxon avatar Mar 28 '24 18:03 sierra-moxon