Started "improving" the Globals panel

[themaks]

• "Name" and "Address" are now 2 separate columns, for readability
• Double clicking on a row jumps to the typedef/enum/struct definition, or on the variable's address

Depends on https://github.com/binsync/libbs/pull/125

DRAFT, still under tests

[mahaloz]

Hey @themaks is this PR ready for review? Thanks so much for your contributions so far. They've been great :)

[themaks]

Yes, this seems to work well, I ll let you test! Just a quick thing that is still buggy: the search function does not work as intended (if I remember correctly, it does not search in the Name column)

[mahaloz]

Hey @themaks, sorry for the delay in the review. I'd love to merge this, but you were right, the search feature no longer works. Previously, you could search by:

• name
• committer

But now it seems you can only search by Type V, E, T, ... This is a big enough breaking change when dealing with large binaries. Any chance you could fix this? I think it's just a bug with what is the text content of the row.

[themaks]

Thanks for looking into it, I'll check this morning!

sorry for the delay

This is an open source project you're gracefully giving time to, no need to feel sorry about anything 😁

[themaks]

This is fixed, all types of searches work now:

• by type (T, S, E, V)
• by name
• by address (lowercase hex, as displayed in the table)
• by author

Cheers

[mahaloz]

Nicely done! Everything works great now!