Stanislav Motylkov
Stanislav Motylkov
I have noticed another difference: the lead/pad voice has no chorus-like effect in AdPlug, so the same voice sounds better using SBFMDRV driver. But this is for another issue.
Temporary quick-fix is committed in https://github.com/adplug/adplug/commit/4f7d41e9f3c1966f5e77f368076aa971c2ce97a2. Leaving the issue open for a proper fix.
binio endian helpers can also operate on memory buffers, iirc.
Is this in sync with upstream? (if not, any chance to send patch upstream?)
Yes, mid.cpp replay code is not perfect. Recently there were some fixes against it, but it still doesn't play the drums correctly (and maybe some instruments as well). This could...
Useful hints for those who will code a player for this format: - M32 vs. others detection - There's 0 instruments in M32 file (`instCount = FileSize - instOffset /...
Work in progress now. You can track the development in [`herad-dev`](https://github.com/adplug/adplug/tree/herad-dev) branch.
It has been merged into master some years ago, but it still has issues (i.e. playback is not perfect in some places), that's why this issue is still not resolved.
See comments on this and next lines: https://github.com/adplug/adplug/blob/6cfb13795eb511d64bc2dcb7caf063fe02798934/src/herad.cpp#L30
> - HERAD v1 vs. v2 detection > - Loop through all instruments > - If the first byte (`inst.mode`) is equal to 0, then it's version 1, break loop...