dirac icon indicating copy to clipboard operation
dirac copied to clipboard

Missing is<Browser> methods with recent versions of ClojureScript

Open paulbutcher opened this issue 4 years ago • 0 comments

I'm getting a number of warnings about missing is<Browser> methods when compiling with recent versions of ClojureScript (it seems to have been introduced by version 1.10.896):

[Figwheel:WARNING] Compile Warning   resources/public/cljs-out/dirac/runtime/util.cljs   line:32  column:22

  Use of undeclared Var goog.labs.userAgent.browser/isOpera

  27  
  28  (defn platform-str [name name-placeholder version version-placeholder]
  29    (str (str-or-placeholder name name-placeholder) "/" (str-or-placeholder version version-placeholder)))
  30  
  31  (defn get-browser-version-info []
  32    (let [browser-name (get-current-browser-name)
                           ^---
  33          browser-version (ua-browser/getVersion)]
  34      (platform-str browser-name "?" browser-version "?")))
  35  
  36  (defn get-browser-platform-info []
  37    (let [platform-name (get-current-platform-name)

[Figwheel:WARNING] Compile Warning   resources/public/cljs-out/dirac/runtime/util.cljs   line:32  column:22

  Use of undeclared Var goog.labs.userAgent.browser/isIE

  27  
  28  (defn platform-str [name name-placeholder version version-placeholder]
  29    (str (str-or-placeholder name name-placeholder) "/" (str-or-placeholder version version-placeholder)))
  30  
  31  (defn get-browser-version-info []
  32    (let [browser-name (get-current-browser-name)
                           ^---
  33          browser-version (ua-browser/getVersion)]
  34      (platform-str browser-name "?" browser-version "?")))
  35  
  36  (defn get-browser-platform-info []
  37    (let [platform-name (get-current-platform-name)

[Figwheel:WARNING] Compile Warning   resources/public/cljs-out/dirac/runtime/util.cljs   line:32  column:22

  Use of undeclared Var goog.labs.userAgent.browser/isEdge

  27  
  28  (defn platform-str [name name-placeholder version version-placeholder]
  29    (str (str-or-placeholder name name-placeholder) "/" (str-or-placeholder version version-placeholder)))
  30  
  31  (defn get-browser-version-info []
  32    (let [browser-name (get-current-browser-name)
                           ^---
  33          browser-version (ua-browser/getVersion)]
  34      (platform-str browser-name "?" browser-version "?")))
  35  
  36  (defn get-browser-platform-info []
  37    (let [platform-name (get-current-platform-name)

[Figwheel:WARNING] Compile Warning: Use of undeclared Var goog.labs.userAgent.browser/isFirefox  resources/public/cljs-out/dirac/runtime/util.cljs   line:32  column:22
[Figwheel:WARNING] Compile Warning: Use of undeclared Var goog.labs.userAgent.browser/isSafari  resources/public/cljs-out/dirac/runtime/util.cljs   line:32  column:22
[Figwheel:WARNING] Compile Warning: Use of undeclared Var goog.labs.userAgent.browser/isCoast  resources/public/cljs-out/dirac/runtime/util.cljs   line:32  column:22
[Figwheel:WARNING] Compile Warning: Use of undeclared Var goog.labs.userAgent.browser/isChrome  resources/public/cljs-out/dirac/runtime/util.cljs   line:32  column:22
[Figwheel:WARNING] Compile Warning: Use of undeclared Var goog.labs.userAgent.browser/isChrome  resources/public/cljs-out/dirac/runtime/repl.cljs   line:23  column:13
[Figwheel:WARNING] Compile Warning: Use of undeclared Var goog.labs.userAgent.browser/isChrome  resources/public/cljs-out/devtools/async.cljs   line:13  column:14
[Figwheel:WARNING] Compile Warning: Use of undeclared Var goog.labs.userAgent.browser/isChrome  resources/public/cljs-out/devtools/formatters.cljs   line:17  column:13

It looks like these methods have been removed from Google Closure Library. As far as I can see get-current-browser-name is only used within the various different transit.json files, and as I'm unfamiliar with what these do within Dirac, I'm not sure what the right fix might be?

paulbutcher avatar Jan 04 '22 09:01 paulbutcher