Bill Denney

Results 328 comments of Bill Denney

There is lots to say here: 1. I emailed you about being a maintainer. As a related note to that, does it make sense to keep `tabyl` or should the...

It's not a strong need, so no need to add if there's hesitation.

While I do a lot in the `clean_names()` space, I don't do almost any database work.

@sfirke , Hopefully this can make the next CRAN release.

I think that the preferred method here would be to add a `convert_to_time()` function that would perform similar work to `convert_to_date()`.

Thanks for the PR. I agree that the feature is useful. I have two comments on the code: 1. Please ensure that it is an error if the column name...

I'll try to pull something like this into the #340 rewrite.

I realized that I missed this feature in the `clean_names()` rewrite. What is the advantage of `abbreviate()` over simply using `substr()`? Also, `abbreviate()` appears not to always actually shorten the...

@jzadra, I was thinking that if we went down a path with a lot of controls for how abbreviation happens, then we may want another pair of functions (e.g. `make_abbrev_names()`...

As I've been thinking about this more, it may be simpler to use a heuristic like the following: * If all values in a column are >=0 and =1 or