Salvatore Ingala

Results 67 issues of Salvatore Ingala

### Intro and context The upcoming version of the Ledger bitcoin app (version 2.1.0) will remove support to the legacy API (1.*). A number of limitations of the 2.* protocol...

Support for multisig via wallet policies was added in #8041; however, the `hmac` that the device returns after registering a wallet policy is not persisted across sessions. Storing the `hmac`...

hw-ledger

Initial version posted to [bitcoin-dev in May](https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2022-May/020423.html). Wallet policies are implemented in the [Ledger bitcoin app](https://github.com/LedgerHQ/app-bitcoin-new) (since version 2.1.0). The following PR experimenting with an HWI integration might provide more...

New BIP

Hello, this in an exploratory PR as a proof of concept of how wallet policies could look like in HWI. Wallet policies [were presented](https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2022-May/020423.html) to the bitcoin-dev mailing list back...

Extend wallet policies with `musig` support, as tentatively specified [here](https://github.com/achow101/bips/blob/musig2-descriptors/bip-musig2-descriptors.mediawiki). For wallet policies, expressions of the form: ``` musig(KEY, ..., KEY)//* musig(KEY, ..., KEY)/** ``` will suffice; `KEY` can be...

enhancement

After #252, we could consider rewording the screens in the wallet registration so that it says "Continue" instead of "Approve", except for the final step, which is actually the user...

ux

The test `test_register_wallet_tr_with_nums_keypath` added in #250 explicitly needs to check that the key `@0` in the wallet policy is correctly identified as `dummy`. The test currently relies on the screenshot....

tests

The recently introduced [lib_standard_app](https://github.com/LedgerHQ/ledger-secure-sdk/tree/master/lib_standard_app) made multiple modules in the app redundant.