missing icon indicating copy to clipboard operation
missing copied to clipboard

Update 40-aria.md

Open geoffrey-eisenbarth opened this issue 1 year ago • 5 comments

Fix js links and add menu button to example.

geoffrey-eisenbarth avatar Jan 28 '24 02:01 geoffrey-eisenbarth

Oh, I'm actually not sure if the JS link changes are necessary because of this (although the js links are currently broken).

I do think adding the <button> in the menu example is helpful tho.

geoffrey-eisenbarth avatar Jan 28 '24 02:01 geoffrey-eisenbarth

I agree about the button. Always good to provide clarity. I do not think the JS changes are necessary in the template though. At least during testing on my local machine, copying those files into missing-js/ made those components work.

fkscott avatar Jan 28 '24 15:01 fkscott

@fkscott I'm not particularly familiar with the way this repo is set up. Given your change, what needs to happen for the links to work on the docs website? The release of 1.1.2?

When I have a second, I'll undo the URL changes in this PR, just juggling right now.

geoffrey-eisenbarth avatar Jan 28 '24 15:01 geoffrey-eisenbarth

Correct, the release of 1.1.2 should fix the links. Making the missing-js folder accessible by the website means none of the markup has to change.

fkscott avatar Jan 28 '24 17:01 fkscott

Okay, should be good. I've never used GitHub to directly edit files and create PRs, so please let me know if something looks off. The only thing in this PR should be adding the button in the tabs example.

geoffrey-eisenbarth avatar Jan 29 '24 14:01 geoffrey-eisenbarth

unfortunately I missed this PR and applied the same fix myself. Thanks either way for contributing

dz4k avatar Jun 13 '24 16:06 dz4k