biomedical icon indicating copy to clipboard operation
biomedical copied to clipboard
verified publisher icon bigscience-workshop

Closes #501 : BEAR Dataset

Open karthikrangasai opened this issue 3 years ago • 4 comments

Closes #501

Checkbox

  • [x] Confirm that this PR is linked to the dataset issue.
  • [x] Create the dataloader script biodatasets/my_dataset/my_dataset.py (please use only lowercase and underscore for dataset naming).
  • [x] Provide values for the _CITATION, _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _BIGBIO_VERSION variables.
  • [x] Implement _info(), _split_generators() and _generate_examples() in dataloader script.
  • [x] Make sure that the BUILDER_CONFIGS class attribute is a list with at least one BigBioConfig for the source schema and one for a bigbio schema.
  • [x] Confirm dataloader script works with datasets.load_dataset function.
  • [x] Confirm that your dataloader script passes the test suite run with python -m tests.test_bigbio biodatasets/my_dataset/my_dataset.py.
  • [ ] If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

karthikrangasai avatar Apr 23 '22 15:04 karthikrangasai

@karthikrangasai this looks good but I notice some of the relations are missing in the training data - is this a facet of the dataset (hence why the unit-tests may fail?)

hakunanatasha avatar Apr 27 '22 05:04 hakunanatasha

Hello @hakunanatasha ,

When I ran the tests locally, all of them passed. Let me check once again though to verify.

karthikrangasai avatar Apr 27 '22 05:04 karthikrangasai

Hello @hakunanatasha ,

I ran the tests again and removed some unwanted lines of code. All the tests pass.

karthikrangasai avatar Apr 27 '22 07:04 karthikrangasai

@hakunanatasha , could you please review the changes to the PR

karthikrangasai avatar May 02 '22 05:05 karthikrangasai