gruf icon indicating copy to clipboard operation
gruf copied to clipboard

Rails 7.1: DEPRECATION WARNING: Calling `ActiveRecord::Base.clear_active_connections! is deprecated. Please call the method directly on the connection handler; for example: `ActiveRecord::Base.connection_handler.clear_active_connections!

Open andreavocado opened this issue 1 year ago • 1 comments

Please describe the issue

When running run_rpc method from gruf-rspec under Rails 7.1 the deprecation warning "DEPRECATION WARNING: Calling ActiveRecord::Base.clear_active_connections! is deprecated. Please call the method directly on the connection handler; for example: ActiveRecord::Base.connection_handler.clear_active_connections!" is shown.

This line should be migrated: https://github.com/bigcommerce/gruf/blob/8ea05f61784ea48c202018496148a1f42b7271b1/lib/gruf/interceptors/active_record/connection_reset.rb#L36

How to Reproduce

Steps to reproduce the behavior:

Run any test with run_rpc method from gruf-rspec

What should happen?

The connection is cleared on the connection handler of AR and the deprecation warning is gone.

Anything else we should know?

  • gruf-2.19.0
  • gruf-rspec-1.0.0
  • rails-7.1.2
  • Ruby 3.2.3

andreavocado avatar Feb 14 '24 14:02 andreavocado

It appears in logs while using rails 7.1 with gruf in general not just with gruf-rspec

On an unrelated note, @splittingred is it just you maintaining gruf at the moment?

Abdullah-l avatar Feb 23 '24 00:02 Abdullah-l