form validation fix
What?
Adding name field validation message for product reviews form.
Screenshots
@Dpschu2 please add a description to the PR and a corresponding screenshot/video confirming the fix. Thanks!
Added the screenshot showing the field message that was missing. The description already describes what was added/missing.
Added the screenshot showing the field message that was missing. The description already describes what was added/missing.
please also remove tickets / documentation block from description if we don't have tickets for it
Also please do not forget to squash commits with one appropriate message
Description updated. How do you squash commits?
Here is what I tried. Did that work?
Description updated. How do you squash commits?
Here is what I tried. Did that work?
yep, you can use git rebase -i HEAD~3 and after that in editor use commands pick and squash to define main commit. As result you will get one commit instead of three.
I originally did that by making the first one 'pick' and the last 2 'squash'. Doing it now gives me commits from past PRs:
Here is what I did:
@Dpschu2 do you mind doing a rebase? I tried to do it for you but I don't have access to your fork. This is good to go after rebase.
