cornerstone icon indicating copy to clipboard operation
cornerstone copied to clipboard

form validation fix

Open Dpschu2 opened this issue 1 year ago • 7 comments

What?

Adding name field validation message for product reviews form.

Screenshots

Added name field validation

Dpschu2 avatar Jul 15 '24 15:07 Dpschu2

@Dpschu2 please add a description to the PR and a corresponding screenshot/video confirming the fix. Thanks!

bc-yevhenii-buliuk avatar Jul 16 '24 12:07 bc-yevhenii-buliuk

Added the screenshot showing the field message that was missing. The description already describes what was added/missing.

Dpschu2 avatar Jul 16 '24 13:07 Dpschu2

Added the screenshot showing the field message that was missing. The description already describes what was added/missing.

please also remove tickets / documentation block from description if we don't have tickets for it

Also please do not forget to squash commits with one appropriate message

bc-yevhenii-buliuk avatar Jul 16 '24 15:07 bc-yevhenii-buliuk

Description updated. How do you squash commits?

Here is what I tried. Did that work? image

Dpschu2 avatar Jul 16 '24 16:07 Dpschu2

Description updated. How do you squash commits?

Here is what I tried. Did that work? image

yep, you can use git rebase -i HEAD~3 and after that in editor use commands pick and squash to define main commit. As result you will get one commit instead of three.

bc-yevhenii-buliuk avatar Jul 16 '24 17:07 bc-yevhenii-buliuk

I originally did that by making the first one 'pick' and the last 2 'squash'. Doing it now gives me commits from past PRs: image

Dpschu2 avatar Jul 16 '24 17:07 Dpschu2

Here is what I did: Screenshot 2024-07-16 at 12 53 14 PM

image

Dpschu2 avatar Jul 16 '24 17:07 Dpschu2

@Dpschu2 do you mind doing a rebase? I tried to do it for you but I don't have access to your fork. This is good to go after rebase.

bookernath avatar Oct 19 '24 16:10 bookernath