catalyst icon indicating copy to clipboard operation
catalyst copied to clipboard

Move Homepage Carousel Data/Queries to page-data.ts file

Open electricenjindevops opened this issue 1 year ago • 2 comments

What/Why?

I recommended that pages be normalized, either all using page-data.ts files, or none using them, for consistency. This seemed to be pretty agreeable so I've made a pull request that starts the process of using a page-data.ts file for home.

Testing

Frontend was not changed for the outcome / client display so existing component/UI tests will work the same. The only difference is that the query logic for the carousel's newest & featured products now lives in an imported page-data.ts file instead of within the main page.tsx file for the default locale's home "/" route.

electricenjindevops avatar May 30 '24 13:05 electricenjindevops

⚠️ No Changeset found

Latest commit: 7430b77ff2925fc14a1e5d44ead0bb36c88d5c8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar May 30 '24 13:05 changeset-bot[bot]

@electricenjindevops is attempting to deploy a commit to the BigCommerce Platform Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 30 '24 13:05 vercel[bot]

Hey @electricenjindevops 👋 !

I just merged some changes to the repo in an effort to normalize some patterns. As of right now, we'll keep page-data only for requests that need to be used multiple times and/or shared. However, we appreciate your feedback and we'll keep in mind your recommendation and further consider it as we normalize more ideas.

For now I will close this PR, and give a nudge if we ever want to move in one direction or another. Thanks!

jorgemoya avatar Aug 26 '24 18:08 jorgemoya

Hey @electricenjindevops 👋 !

I just merged some changes to the repo in an effort to normalize some patterns. As of right now, we'll keep page-data only for requests that need to be used multiple times and/or shared. However, we appreciate your feedback and we'll keep in mind your recommendation and further consider it as we normalize more ideas.

For now I will close this PR, and give a nudge if we ever want to move in one direction or another. Thanks!

Thanks Jorge, I appreciate the explanation!

electricenjindevops avatar Aug 26 '24 19:08 electricenjindevops