greenlight icon indicating copy to clipboard operation
greenlight copied to clipboard

Room owner option: authentication is required to join a room

Open ucb-ck opened this issue 4 years ago • 7 comments

117446677-b553d200-af3c-11eb-8ce2-569b6b3080e0 117446675-b4bb3b80-af3c-11eb-89c0-f5e4122b7c4f

Description

Added a new room option which allows room owners to configure if authentication is required before a specific room can be joined. Clarified german translation to reflect distinction between settings for all rooms of a gl instance and single rooms.

Organization - Site Settings - Settings - Require Authentication for Rooms enabled: options in room settings and global room configuration disappear disabled: option in room settings is configurable (see below)

Organization - Room Configuration - Require authentication before joining enabled: has the same effect as setting "Require Authentication for Rooms" to enabled optional: room owners are able to configure this setting disabled: room owners are not able to configure this setting, disabled for all rooms

##Testing Steps

add require-authentication-to-join to ROOM_FEATURES in .env restart greenlight

ucb-ck avatar May 10 '21 09:05 ucb-ck

Closes #1714

feature request: 'Allow only logged in users' in Room settings

ucb-ck avatar May 10 '21 09:05 ucb-ck

Why this feature wasn't merged ? It would some peoples. @ffdixon others ? thanks

jgribonvald avatar Sep 02 '21 17:09 jgribonvald

A usefull feature working well ! I've tested it and it's work well, I merged it on the last greenligth version and it's working well, will go on production with it next week.

@ucb-ck I've made a Pull request on your repo/branch to provide the French translation.

I hope my comment will help to merge this usefull feature !

jgribonvald avatar Sep 03 '21 16:09 jgribonvald

@farhatahmad Could you please take a closer look and see if you can merge it?

GhaziTriki avatar Sep 21 '21 13:09 GhaziTriki

Is there a chance that this feature will be merged soon?

beckerr-rzht avatar Sep 25 '21 11:09 beckerr-rzht

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

sonarqubecloud[bot] avatar Oct 06 '21 08:10 sonarqubecloud[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

sonarqubecloud[bot] avatar Nov 22 '21 06:11 sonarqubecloud[bot]